Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Argon2 #150

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add support for Argon2 #150

wants to merge 2 commits into from

Conversation

maandree
Copy link

Dependencies:

Compatible with the reference implementation of Argon2, but it also supports (not documented; libar2simplified adds this) replacing the salt or hash with their length encoded as asterisk-prefixed, decimal integers; if this is done with the salt, a random salt is generated.

@besser82 besser82 requested review from zackw and besser82 February 15, 2022 18:42
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Patch coverage has no change and project coverage change: +2.87 🎉

Comparison is base (a2129ae) 88.58% compared to head (1b88359) 91.46%.

❗ Current head 1b88359 differs from pull request most recent head e72e23e. Consider uploading reports for the commit e72e23e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #150      +/-   ##
===========================================
+ Coverage    88.58%   91.46%   +2.87%     
===========================================
  Files           32       10      -22     
  Lines         3618      527    -3091     
  Branches       690       86     -604     
===========================================
- Hits          3205      482    -2723     
+ Misses         228       25     -203     
+ Partials       185       20     -165     

see 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

doc/crypt.5 Outdated
.Ss argon2_d
argon2_d is one of the variants of Argon2 key derivation functions that won
the Password Hashing Competition 2015. argon2d is designed for environments
taht are safe from side-channel attacks. Acceptable for new hashes, but
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

doc/crypt.5 Outdated
.Ss argon2_i
argon2_i is one of the variants of Argon2 key derivation functions that won
the Password Hashing Competition 2015. argon2i is designed for environments
taht are not safe from side-channel attacks. Acceptable for new hashes, but
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same typo as above

@rathann rathann mentioned this pull request Jun 22, 2023
Signed-off-by: Mattias Andrée <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants