Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated @types/puppeteer version #302

Closed
dgergely opened this issue Aug 29, 2020 · 6 comments
Closed

Outdated @types/puppeteer version #302

dgergely opened this issue Aug 29, 2020 · 6 comments

Comments

@dgergely
Copy link

In the file packages/puppeteer-extra/package.json the version for @types/puppeteer is ^2.0.0, however 3.0.1 is already out.
Since package.json sets the version, I have to use that one, otherwise both versions are installed and incompatibility issues rise.

Is there any reason for pinning version 2.x?

@berstend
Copy link
Owner

This will be fixed with #303 :-)

@berstend
Copy link
Owner

In the meantime you could overwrite the version in your own package.json (untested):

  "resolutions": {
    "**/@types/puppeteer": "3.0.1"
  },

@dgergely
Copy link
Author

@berstend sounds great! Thanks! Any estimation when it will be released?

@berstend
Copy link
Owner

It's a complete rewrite basically, so I want to make sure nothing breaks :-) Updating tests, etc. is pretty time-consuming but it shouldn't be too long until the new version is out.

@berstend
Copy link
Owner

berstend commented Sep 2, 2020

Closing for now, let me know if the above mentioned hotfix isn't working.

@berstend berstend closed this as completed Sep 2, 2020
@sebastianhaberey
Copy link

sebastianhaberey commented Jan 10, 2021

Apparently, due to an open issue, resolutions doesn't work with deps that have '/' in their name.

The above mentioned hotfix is not working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants