Conversation
wuphilipp
approved these changes
Sep 3, 2020
Collaborator
wuphilipp
left a comment
There was a problem hiding this comment.
Looks good, I tested the README instructions on freshly cloned blue_core repos in kinetic and melodic, so hopefully, that's good enough verification.
we should probably try to get some CI running for the code base
Collaborator
|
Also should we update the README to note noetic support? |
Member
|
I was going to offer to check on both but it seems like Philipp's a step ahead. Feel free to PR after addressing his comments. |
gbalke
approved these changes
Sep 3, 2020
Collaborator
Author
Gonna hold off on this because:
|
Collaborator
Sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been trying to get
blue_coreto build in 20.04; the main things blocking this have been dependency-related:orocos_kdlkeys have been removed (Add rosdep rules for orocos kdl and orocos bfl ros/rosdistro#23841)Building from source works fine for fixing the first point; this PR fixes the second by pointing the orocos dependency at apt.
Should just magically work in Kinetic/Melodic, but would appreciate if someone could check!