Skip to content

Fix rosdeps for Noetic, CMake cleanup, add CI#96

Merged
brentyi merged 14 commits into
masterfrom
noetic
Sep 3, 2020
Merged

Fix rosdeps for Noetic, CMake cleanup, add CI#96
brentyi merged 14 commits into
masterfrom
noetic

Conversation

@brentyi
Copy link
Copy Markdown
Collaborator

@brentyi brentyi commented Sep 3, 2020

I've been trying to get blue_core to build in 20.04; the main things blocking this have been dependency-related:

Building from source works fine for fixing the first point; this PR fixes the second by pointing the orocos dependency at apt.

Should just magically work in Kinetic/Melodic, but would appreciate if someone could check!

@brentyi brentyi requested review from gbalke and wuphilipp September 3, 2020 06:47
Copy link
Copy Markdown
Collaborator

@wuphilipp wuphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tested the README instructions on freshly cloned blue_core repos in kinetic and melodic, so hopefully, that's good enough verification.

we should probably try to get some CI running for the code base

Comment thread blue_controller_manager/package.xml
@wuphilipp
Copy link
Copy Markdown
Collaborator

Also should we update the README to note noetic support?

@gbalke
Copy link
Copy Markdown
Member

gbalke commented Sep 3, 2020

I was going to offer to check on both but it seems like Philipp's a step ahead. Feel free to PR after addressing his comments.

@brentyi brentyi changed the title Replace kdl packages with rosdep keys for Noetic Replace kdl packages with rosdep keys for Noetic + CI Sep 3, 2020
@brentyi
Copy link
Copy Markdown
Collaborator Author

brentyi commented Sep 3, 2020

Also should we update the README to note noetic support?

Gonna hold off on this because:

  • serial package still needs to be built from source
  • All of the Python bits will run in Python3 on Noetic; this is not thoroughly tested

@wuphilipp
Copy link
Copy Markdown
Collaborator

Also should we update the README to note noetic support?

Gonna hold off on this because:

  • serial package still needs to be built from source
  • All of the Python bits will run in Python3 on Noetic; this is not thoroughly tested

Sounds good!

@brentyi brentyi changed the title Replace kdl packages with rosdep keys for Noetic + CI Fix rosdeps for Noetic, CMake cleanup, add CI Sep 3, 2020
@brentyi brentyi merged commit a4d32f3 into master Sep 3, 2020
@brentyi brentyi deleted the noetic branch September 3, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants