fix(export): Support typescript namespaces#1320
Merged
ljharb merged 1 commit intoimport-js:masterfrom Apr 12, 2019
bradzacher:export-ts-namespaces
Merged
fix(export): Support typescript namespaces#1320ljharb merged 1 commit intoimport-js:masterfrom bradzacher:export-ts-namespaces
ljharb merged 1 commit intoimport-js:masterfrom
bradzacher:export-ts-namespaces
Conversation
3 similar comments
Member
|
Hmm, I just pushed up a commit to deal with "Fixed broken test on ESLint v3 caused by old typescript parser" by skipping the test on eslint < 4. Does that mean this PR fixes the test so it passes? If so, please rebase and revert my change in the process :-) |
Contributor
Author
|
@ljharb - rebased on top! Yeah the error was happening because in the old version of typescript which got installed with eslint v3 produced a different AST, hence that case wasn't handled. Not sure why it worked fine on the PR then failed on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1300