Brand logo is hidden when --quiet is in use.

About text added to --help.
Improved error feedback for directory args.
Permission errors are returned for directories
but not the sub-directories.

Author: bengarrett

internal/misc/misc.go

@@ -15,7 +15,7 @@ type (
 
 const Filename = "-zipcomment.txt"
 
-// unique checks the destination path against an export map.
+// Unique checks the destination path against an export map.
 // The map contains a unique collection of previously used destination
 // paths, to avoid creating duplicate text filenames while using the
 // SaveName config.

main.go

@@ -67,7 +67,7 @@ func main() { // nolint: funlen
 		help(true)
 	}
 	flag.Parse()
-	flags(ver, aliasV)
+	flags(ver, aliasV, aliasQ)
 	// parse aliases
 	if *aliasR {
 		c.NoWalk = true
@@ -100,31 +100,32 @@ func main() { // nolint: funlen
 	}
 }
 
-func flags(ver, aliasV *bool) {
+func flags(ver, aliasV, quiet *bool) {
 	// convenience for when a help or version flag is passed as an argument
 	for _, arg := range flag.Args() {
+		showLogo := !*quiet
 		switch strings.ToLower(arg) {
 		case "-h", "-help", "--help":
-			help(true)
+			help(showLogo)
 			os.Exit(0)
 		case "-v", "-version", "--version":
-			info()
+			info(quiet)
 			os.Exit(0)
 		}
 	}
 	// print version information
 	if *ver || *aliasV {
-		info()
+		info(quiet)
 		os.Exit(0)
 	}
 	// print help if no arguments are given
 	if len(flag.Args()) == 0 {
 		if runtime.GOOS == winOS {
-			color.Warn.Println("zipcmt requires at least one directory or drive letter to scan")
+			fmt.Fprintln(os.Stderr, color.Warn.Sprint("zipcmt requires at least one directory or drive letter to scan"))
 		} else {
-			color.Warn.Println("zipcmt requires at least one directory to scan")
+			fmt.Fprintln(os.Stderr, color.Warn.Sprint("zipcmt requires at least one directory to scan"))
 		}
-		fmt.Println()
+		fmt.Fprintln(os.Stderr)
 		help(false)
 		os.Exit(0)
 	}
@@ -175,10 +176,10 @@ func help(logo bool) {
 	var f *flag.Flag
 	if logo {
 		fmt.Fprintln(os.Stderr, brand)
+		fmt.Fprint(os.Stderr, " Zip Comment is the super-fast batch, zip file comment viewer, and extractor.\n"+
+			" Using a modern PC with the zip files stored on a solid-state drive,\n"+
+			" zipcmt handles many thousands of archives per second.\n\n")
 	}
-	fmt.Fprint(os.Stderr, " Zip Comment is the super-fast batch, zip file comment viewer, and extractor.\n"+
-		" Using a modern PC with the zip files stored on a solid-state drive,\n"+
-		" zipcmt handles many thousands of archives per second.\n\n")
 	fmt.Fprintln(os.Stderr, "Usage:")
 	if runtime.GOOS == winOS {
 		helpWin()
@@ -229,9 +230,11 @@ func optimial(w *tabwriter.Writer) {
 }
 
 // Info prints out the program information and version.
-func info() {
+func info(quiet *bool) {
 	const copyright = "\u00A9"
-	fmt.Println(brand)
+	if !*quiet {
+		fmt.Println(brand)
+	}
 	fmt.Printf("zipcmt v%s\n%s 2021-22 Ben Garrett, logo by sensenstahl\n", version, copyright)
 	fmt.Printf("https://github.com/bengarrett/zipcmt\n\n")
 	fmt.Printf("build: %s (%s)\n", commit, date)

pkg/zipcmt.go

@@ -84,12 +84,13 @@ type (
 )
 
 var (
-	ErrFlag    = errors.New("directories to scan must be listed after any option flags")
-	ErrIsFile  = errors.New("directory is a file")
-	ErrMissing = errors.New("directory cannot be found")
-	ErrPath    = errors.New("directory path cannot be found or points to a file")
-	ErrPerm    = errors.New("directory access is blocked due to its permissions")
-	ErrValid   = errors.New("the operating system reports this directory is invalid")
+	ErrFlag     = errors.New("this option is used after a directory, it must be placed before any directories are listed")
+	ErrDirExist = errors.New("directory does not exist")
+	ErrIsFile   = errors.New("directory is a file")
+	ErrMissing  = errors.New("directory cannot be found")
+	ErrPath     = errors.New("directory path cannot be found or points to a file")
+	ErrPerm     = errors.New("directory access is blocked due to its permissions")
+	ErrValid    = errors.New("the operating system reports this directory is invalid")
 )
 
 // Read the named zip file and return the zip comment.
@@ -142,7 +143,11 @@ func (c *Config) WalkDir(root string) error { // nolint: cyclop,funlen,gocognit
 	err := filepath.WalkDir(root, func(path string, d fs.DirEntry, err error) error {
 		if err != nil {
 			if errors.Is(err, fs.ErrPermission) {
-				return nil
+				// skip permission errors for subdirectories
+				// but return an error if the root is inaccessible
+				if root != path {
+					return nil
+				}
 			}
 			return err
 		}
@@ -156,7 +161,8 @@ func (c *Config) WalkDir(root string) error { // nolint: cyclop,funlen,gocognit
 		}
 		c.Zips++
 		if !c.test && !c.Print && !c.Quiet {
-			fmt.Print("\r", color.Secondary.Sprint("Scanned "), color.Primary.Sprintf("%d zip archives", c.Zips))
+			fmt.Print("\r", color.Secondary.Sprint("Scanned "),
+				color.Primary.Sprintf("%d zip archives", c.Zips))
 		}
 		// read zip file comment
 		cmmt, err := Read(path, c.Raw)
@@ -200,7 +206,8 @@ func (c *Config) WalkDir(root string) error { // nolint: cyclop,funlen,gocognit
 			dat.name = c.exports.Unique(path, c.SaveName)
 			c.names += len(dat.name)
 			if c.save(dat) {
-				c.WriteLog(fmt.Sprintf("SAVED: %s (%s) << %s", dat.name, humanize.Bytes(uint64(len(cmmt))), path))
+				c.WriteLog(fmt.Sprintf("SAVED: %s (%s) << %s",
+					dat.name, humanize.Bytes(uint64(len(cmmt))), path))
 				c.saved++
 			}
 		}
@@ -213,8 +220,18 @@ func walkErrs(root string, err error) error {
 	var pathError *os.PathError
 	if errors.As(err, &pathError) {
 		if root != "" && root[:1] == "-" {
-			return fmt.Errorf("detected an options flag, %w: %s", ErrFlag, root)
+			return fmt.Errorf("%w: %s", ErrFlag, root)
+		}
+	}
+	if errors.Is(err, os.ErrNotExist) {
+		return fmt.Errorf("%w: %s", ErrDirExist, root)
+	}
+	if errors.Is(err, fs.ErrPermission) {
+		f, err := os.Stat(root)
+		if err != nil {
+			return fmt.Errorf("%w: %s", ErrPerm, root)
 		}
+		return fmt.Errorf("%w: %s, %s", ErrPerm, f.Mode(), root)
 	}
 	if err != nil {
 		return fmt.Errorf("walk directory: %s, %w %T", root, err, err)