From 85a93b083c9232f5b305c669e4d148b7534b6d14 Mon Sep 17 00:00:00 2001 From: Ben Fry Date: Thu, 24 Nov 2022 18:15:10 -0500 Subject: [PATCH] notes about #592 and pull #597 --- core/src/processing/core/PShape.java | 6 +++--- core/todo.txt | 8 +++----- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/core/src/processing/core/PShape.java b/core/src/processing/core/PShape.java index 1eb7a3fa4..3d7118368 100644 --- a/core/src/processing/core/PShape.java +++ b/core/src/processing/core/PShape.java @@ -1985,10 +1985,10 @@ static protected PImage parseBase64Image(String imagePath) { String extension = parts[0].substring(11); String encodedData = parts[1]; + // Fix for https://github.com/processing/processing4/issues/592 // If a SVG image has an error, the base 64 will fail, but the browser will work. - // So we are sanitizing the values before reading it. - // If you have any questions, please, read this - // reference: https://www.prostdev.com/post/understanding-the-illegal-base64-character-error-java-groovy-and-mule-4-dw-2-0 + // So we are sanitizing the values before reading it: + // https://www.prostdev.com/post/understanding-the-illegal-base64-character-error-java-groovy-and-mule-4-dw-2-0 Base64.Decoder decoder; if (encodedData.contains("+") || encodedData.contains("/")) { decoder = Base64.getDecoder(); diff --git a/core/todo.txt b/core/todo.txt index db9b5f0a0..06afe20f0 100644 --- a/core/todo.txt +++ b/core/todo.txt @@ -11,6 +11,9 @@ X maybe https://github.com/processing/processing4/issues/487 contribs X P3D & P2D window not showing on MacOS Ventura (thx @jaegonlee) X https://github.com/processing/processing4/issues/544 +X Loading SVG file gives Illegal base64 character 20 encoding error (worked in v3.5.4) +X https://github.com/processing/processing4/issues/592 +X https://github.com/processing/processing4/pull/599 data X use choice() instead of random() for list classes @@ -18,11 +21,6 @@ X remove random(PApplet) since unlikely to be used/seems overkill X add choice() as a PApplet method for int values of random() -contrib -_ Loading SVG file gives Illegal base64 character 20 encoding error (worked in v3.5.4) -_ https://github.com/processing/processing4/issues/592 -_ https://github.com/processing/processing4/issues/592 - _ freeze on resize with Windows (even the default renderer) _ https://github.com/processing/processing4/issues/507