Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tree-shaking #241

Closed
kinday opened this issue Nov 3, 2019 · 2 comments
Closed

Improve tree-shaking #241

kinday opened this issue Nov 3, 2019 · 2 comments

Comments

@kinday
Copy link

kinday commented Nov 3, 2019

Hi there,

I’ve had a quick glance at code and could make a PR, but feels better to ask maintainers first.

There is non-standard (yet widely supported) sideEffect field which, if present in package.json, allows build tools (example from Webpack docs) to better handle tree-shaking.

So, the code (at least of universal-cookie package) seems to be side effect free, but I’d like to get confirmation from you. If you haven’t ever dealt with sideEffects field, in this case we speak about side effects on module evaluation (i.e. import or require).

I tried to cover essential parts, but if further clarification is needed, feel free to ask me.

@eXon
Copy link
Collaborator

eXon commented Nov 5, 2019

Yes I'm sure we can add this. Good idea!

@eXon eXon closed this as completed in cdb3bad Dec 27, 2019
@eXon
Copy link
Collaborator

eXon commented Dec 27, 2019

Done with v4.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants