We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/beman-project/Optional26/blob/bfeb9080c0d9c501965ae857a1decf7ed74686f5/include/Beman/Optional26/optional.hpp#L441
This needs to use (void*)std::addressof(value_)
(void*)std::addressof(value_)
The text was updated successfully, but these errors were encountered:
https://github.com/beman-project/Optional26/blob/bfeb9080c0d9c501965ae857a1decf7ed74686f5/include/Beman/Optional26/optional.hpp#L310
This one needs to vast to void* and use ::new
void*
::new
Sorry, something went wrong.
Also indicates missing test cases that ought not to have compiled, then.
It's a very sneaky one to test for.
construct_at, which was needed for some constexpr cases, avoids the problem.
construct_at
constexpr
Holding off closing until the changes actually land here on main.
steve-downey
No branches or pull requests
https://github.com/beman-project/Optional26/blob/bfeb9080c0d9c501965ae857a1decf7ed74686f5/include/Beman/Optional26/optional.hpp#L441
This needs to use
(void*)std::addressof(value_)
The text was updated successfully, but these errors were encountered: