Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Use of Signedness for Binary and Hex Numbers #108

Open
drocheam opened this issue Nov 6, 2021 · 0 comments
Open

Inconsistent Use of Signedness for Binary and Hex Numbers #108

drocheam opened this issue Nov 6, 2021 · 0 comments

Comments

@drocheam
Copy link

drocheam commented Nov 6, 2021

The HexValReader class converts numbers to a unsigned int value, while the BinValReader converts to a signed int.
This is due to mpValReader.cpp, line 247, where a cast from unsigned int to signed int takes place.

A consistent conversion for both number types, for example to signed int, would be advisable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants