You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 31, 2020. It is now read-only.
I've run some tests against Python 3.7, with 113 falures, but a large percentage of the failures are repeated differences only in the expected exception messages, such as
- <class 'TypeError'> : must be str, not type+ <class 'TypeError'> : can only concatenate str (not "type") to str
That one is really common, with minor variation like str->double etc for each native type. Also common:
- <class 'TypeError'> : not all arguments converted during bytes formatting+ <class 'TypeError'> : %b requires a bytes-like object, or an object that implements __bytes__, not 'int'
I think it would be useful to have the code or test suite handle those differences, so that the real errors stand out more.
The text was updated successfully, but these errors were encountered:
Completely agreed - and there are many places in the existing codebase where we have analogous adaptations for changes in error message introduced by other Python versions.
If you search for uses of if (org.python.VERSION < 0x03040300) {, you'll see how this is being handled for other Python versions.
We'd also need to update our CI infrastructure to support Python 3.8 to provide meaningful testing for this change.
I've run some tests against Python 3.7, with 113 falures, but a large percentage of the failures are repeated differences only in the expected exception messages, such as
That one is really common, with minor variation like str->double etc for each native type. Also common:
Others are like
I think it would be useful to have the code or test suite handle those differences, so that the real errors stand out more.
The text was updated successfully, but these errors were encountered: