Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbar parameter of Window is not used #2043

Closed
NMertsch opened this issue Jul 22, 2023 · 1 comment · Fixed by #2058
Closed

toolbar parameter of Window is not used #2043

NMertsch opened this issue Jul 22, 2023 · 1 comment · Fixed by #2058
Labels
bug A crash or error in behavior.

Comments

@NMertsch
Copy link
Contributor

Describe the bug

Window.__init__(...) has an unused parameter toolbar.

As a user, I'd be surprised if I call Window(..., toolbar=my_custom_widget) and nothing happens.

Steps to reproduce

Expected behavior

Either Window has no toolbar parameter, or it does something.

Screenshots

No response

Environment

(all)

Logs

No response

Additional context

No response

@NMertsch NMertsch added the bug A crash or error in behavior. label Jul 22, 2023
@freakboy3742
Copy link
Member

Thanks for the report. This is a little surprising to me - I can only assume it's an artefact of some very old history, because toolbars are constructed by Commands, not by passing in any argument to Window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A crash or error in behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants