Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is fetchart source fanarttv currently working for anyone? #3826

Closed
Jieiku opened this issue Jan 7, 2021 · 6 comments
Closed

is fetchart source fanarttv currently working for anyone? #3826

Jieiku opened this issue Jan 7, 2021 · 6 comments
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." stale

Comments

@Jieiku
Copy link

Jieiku commented Jan 7, 2021

I am 100% new to beets as well as musicbrainz, however I have been using linux for years.

I am on Ubuntu 20.04 and could not get beets to work with pip3 install beets (#3674)
I did however get up and running by using pip3 to install beets dependencies and then installing beets itself by cloning from gihub

Problem

fanarttv does not seem to work for fetchart

The fetchart plugin is working otherwise because if I add additional sources then the cover is found, just trying to diagnose fanarttv.

In The below command you will notice the verbose output for fetchart searching filesystem, but you never see one for fanarttv.

$ sudo beet -vv import -A -C -W -t "/media/md0/DL/_music/Rock-Hard/Soundgarden/1994 - Superunknown/"

shows this output:

user configuration: /root/.config/beets/config.yaml
data directory: /root/.config/beets
plugin paths:
Sending event: pluginload
library database: /root/.config/beets/library.db
library directory: /root/Music
Sending event: library_opened
Sending event: import_begin
Sending event: import_task_created
/media/md0/DL/_music/Rock-Hard/Soundgarden/1994 - Superunknown
0 of 16 items replaced
Sending event: database_change
...
Sending event: database_change
fetchart: trying source filesystem for album Soundgarden - Superunknown
Sending event: database_change
...
Sending event: database_change
Sending event: import_task_files
Sending event: album_imported
Sending event: import
Sending event: cli_exit

Because the above command never says trying source for fanarttv I decided to try manually:

$ sudo beet -vv fetchart -f "/media/md0/DL/_music/Rock-Hard/Soundgarden/1994 - Superunknown/"

shows this output:

user configuration: /root/.config/beets/config.yaml
data directory: /root/.config/beets
plugin paths:
Sending event: pluginload
library database: /root/.config/beets/library.db
library directory: /root/Music
Sending event: library_opened
fetchart: trying source filesystem for album Soundgarden - Superunknown
fetchart: trying source fanarttv for album Soundgarden - Superunknown
fetchart: Soundgarden - Superunknown: no art found
Sending event: cli_exit

you can now see that it does say trying source for fanarttv however it reports no art found.

However I manually searched fanart.tv using firefox and the album art is absolutely there.

I am wondering if fanart.tv is working with beets for anybody else? or if I have somehow set something up incorrectly.

Setup

  • OS: Ubuntu 20.04
  • Python version: 3.8.5
  • beets version: 1.5.0 (beets-1.5.0-py3.8.egg)
  • Turning off plugins made problem go away (yes/no): no (the issue/question is about the plugin fetchart?)

My configuration (output of beet config) is:

plugins: fetchart
fetchart:
    fanarttv_key: REDACTED
    minwidth: 1000
    cover_names:
    - cover
    - front
    - art
    - album
    - folder
    sources:
    - filesystem
    - fanarttv
@Jieiku
Copy link
Author

Jieiku commented Jan 7, 2021

Also it seems on import it never tries anything other than filesystem for fetchart, its not until I do -f that it actually tries online sources. This is even on directories with nothing but .mp3 files, no images or anything else in the directory.

so when doing a large import it seems it finds no album covers except local filesystem.
I did just notice that I can follow up with beet fetchart -q which should get everything that local filesystem did not have.

@sampsyo sampsyo added the needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." label Jan 7, 2021
@sampsyo
Copy link
Member

sampsyo commented Jan 7, 2021

Interesting! It's hard to say without digging a bit more into the code, since it seems like there is not enough logging to say why the art wasn't found. Maybe throwing some print statements into the appropriate backend would help reveal what's going wrong.

@Jieiku
Copy link
Author

Jieiku commented Jan 7, 2021

I am really interested in getting fanart.tv working, so I will work on this within the next day or so :)

@Jieiku
Copy link
Author

Jieiku commented Jan 8, 2021

I found the problem, after looking at the fanart.tv api it appears you can only search with mbid: https://fanarttv.docs.apiary.io/#reference/music/get-album/get-album

I was using beets to scan for album art without tagging, I already spent a lot of time on my tags and did not want to change them.

Is there a way to get beets to add just the artist and album mbid tags but not change any of the other tags when importing.

@wisp3rwind
Copy link
Member

The write config option might be what you're looking for https://beets.readthedocs.io/en/stable/reference/config.html#write.

@stale
Copy link

stale bot commented Mar 9, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 9, 2021
@stale stale bot closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." stale
Projects
None yet
Development

No branches or pull requests

3 participants