Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bs1770gain 0.6.0 failing initialization #3367

Closed
r3b311i0n opened this issue Sep 14, 2019 · 9 comments
Closed

bs1770gain 0.6.0 failing initialization #3367

r3b311i0n opened this issue Sep 14, 2019 · 9 comments
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."

Comments

@r3b311i0n
Copy link

Problem

bs1770gain failing initialization after upgrading to v0.6.0 from v0.5.2. Downgrading to v0.5.2 fixes the issue.

$ beet replaygain
error: replaygain initialization failed: bs1770gain exited with status 1

Setup

  • OS: Arch Linux
  • Python version: 3.7.4
  • beets version: 1.4.9
  • Turning off plugins made problem go away (yes/no): yes

My configuration is:

directory: ~/Music/ext-music
library: ~/.config/beets/library.db
musicbrainz:
        match:
                ignored_media: ['Data CD', 'DVD', 'DVD-Video', 'Blu-ray',
                                'HD-DVD', 'VCD', 'SVCD', 'UMD', 'VHS']
ui:
        color: yes
        colors:
                text_success: green
                text_warning: yellow
                text_error: red
                text_highlight: red
                text_highlight_minor: lightgray
                action_default: turquoise
                action: blue
import:
        move: yes
        copy: no
        autotag: yes
plugins: [mpdstats, replaygain, embedart, fetchart, convert, info, chroma, fuzzy, zero]
replaygain:
        backend: bs1770gain
        method: ebu
        r128: [Opus, MP3, FLAC, AAC, ALAC, Wave]
embedart:
        ifempty: yes
        remove_art_file: yes
mpd:
        music_directory: ~/Music/ext-music
chroma:
        auto: yes
zero:
        fields: comments genre
        update_database: true
@sampsyo sampsyo added the needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." label Sep 14, 2019
@sampsyo
Copy link
Member

sampsyo commented Sep 14, 2019

Please include the verbose output.

@9ary
Copy link

9ary commented Sep 19, 2019

I've been running into the same problem.

library: ~/music/beets.blb
directory: ~/music
plugins: fetchart embedart replaygain

import:
    move: yes
    group_albums: yes

embedart:
    auto: no

replaygain:
    backend: bs1770gain
    overwrite: yes
    method: replaygain
$ beet -v  
user configuration: /home/streetwalrus/.config/beets/config.yaml
data directory: /home/streetwalrus/.config/beets
plugin paths: 
Sending event: pluginload
error: replaygain initialization failed: bs1770gain exited with status 1

It looks like version 0.6 now exits with 1 if you don't pass it any arguments. Passing -h or --help makes it exit with 0, and it looks like this has already been fixed.
I couldn't find any source code repository for upstream that would explain why this change was made.

@r3b311i0n
Copy link
Author

Sorry for the delay. The output's the same as @Streetwalrus's

$ beet -v                                                                    
user configuration: /home/r3b311i0n/.config/beets/config.yaml
data directory: /home/r3b311i0n/.config/beets
plugin paths: 
Sending event: pluginload
error: replaygain initialization failed: bs1770gain exited with status 1

@cacack
Copy link

cacack commented Oct 26, 2019

I'm getting bit by this too. However, the commit @Streetwalrus found was commit merged in over a year ago, #3065. I think this error is creeping in from somewhere else... The message is coming from: https://github.com/beetbox/beets/blob/master/beetsplug/replaygain.py#L1208, but I haven't had a chance to trace this back to the actual initialization of bs1770gain.

@9ary
Copy link

9ary commented Oct 26, 2019

However, the commit @Streetwalrus found was commit merged in over a year ago, #3065.

Actually, no. The pull request was submitted last year and that's what the commit date is, but looking at the actual thread, it was merged this July, after 1.4.9 was released in May. 1.4.9 definitely does not include the change that I pointed out, and applying it manually fixes the issue on my end.

@cacack
Copy link

cacack commented Oct 26, 2019

🤦‍♂️ Doh! I missed that merge date...

@matzebond
Copy link

So this can be closed and we are just waiting for an updated version in our repos :)

@9ary
Copy link

9ary commented Nov 4, 2019

Yes. I don't know what the plans are for a new release, but in the meantime you can run the latest version from master, make the change yourself, or bug your distro maintainers to patch it for you since they upgraded to an incompatible version.

@sampsyo
Copy link
Member

sampsyo commented Nov 4, 2019

Sounds good; I'll close this now! And note the request for a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."
Projects
None yet
Development

No branches or pull requests

5 participants