Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbcollection: 'remove' option inadvertently removes merged releases #2914

Open
bjin opened this issue May 3, 2018 · 1 comment
Open

mbcollection: 'remove' option inadvertently removes merged releases #2914

bjin opened this issue May 3, 2018 · 1 comment
Labels
bug bugs that are confirmed and actionable

Comments

@bjin
Copy link
Contributor

bjin commented May 3, 2018

Problem

For an album 'A' which is later merged into another album 'B' on MusicBrainz, the MBID of A will be redirected to MBID of B.

If I tried to run beet mbupdate -r with a local collection containing album 'A', it will add album 'B' to my remote collection (redirected on the server side) first. But in the end, 'B' will inadvertently get removed (since mbcollection plugins believes 'B' is not newly added and should be removed).

Steps to reproduce:

  1. Create a local database containing this album.
  2. run beet mbupdate -r

Expected Behavior:

this album is added to remote collection instead of the one with original MBID.

Actual Behavior:

Nothing is added to remote collection. The expected album is added first but later get removed.

Setup

  • OS: Linux
  • Python version: 3.6.5
  • beets version: 1.4.6
  • Turning off plugins made problem go away (yes/no): N/A
@sampsyo sampsyo added the bug bugs that are confirmed and actionable label May 3, 2018
@sampsyo sampsyo changed the title mbcollection: 'remove' option would inadvertently remove certain releases mbcollection: 'remove' option inadvertently removes merged releases May 3, 2018
@sampsyo
Copy link
Member

sampsyo commented May 3, 2018

Thanks for the clear description! That does sound like a real problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

No branches or pull requests

2 participants