Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add translation support #425

Open
beeradmoore opened this issue Feb 23, 2025 · 8 comments
Open

[Feature request] Add translation support #425

beeradmoore opened this issue Feb 23, 2025 · 8 comments
Labels
feature request New feature or request translation

Comments

@beeradmoore
Copy link
Owner

beeradmoore commented Feb 23, 2025

Describe what this adds or solves

DLSS Swapper is currently in English. There have been multiple requests to add support for other languages with members even offering to contribute to translations.

Describe the solution you'd like

Setup the backing translation functionality and provide users a way to contribute translations without having to be fully fledged developers. This could come in the form of documnetation or external tools.

Additional context

According to the docs unpackaged apps just require resw files. There is extra instructions here which require installing Windows SDK to get access to makepri.exe.

That is a lot of extra things for anyone to do, let alone non-developer community members.

I have started a demo project here, however Microsoft.Windows.Globalization.ApplicationLanguages.PrimaryLanguageOverride does not appear to do anything. And having users be able to change their language in the app is a must.

Can functionality be provided with AndrewKeepCoding/WinUI3Localizer
?

I have filed a bug report here to try figure out the above issues of PrimaryLanguageOverride not working.

@beeradmoore beeradmoore added feature request New feature or request translation labels Feb 23, 2025
@DutraGames
Copy link
Contributor

Hey @beeradmoore !

It looks like I wasn’t the only one who brought up the topic of multi-language support.

Good luck with implementing the language system! I believe using a JSON file, for example, could be a viable solution. However, I’m not entirely familiar with the DLSS Swapper structure or how C# handles this functionality.

Also, I really liked the revamped feature request format. It looks great—congratulations on the improvement!

Once you manage to set up language support, please tag me. I’ll be ready to start translating into Brazilian Portuguese, as requested by our colleague in #261, as well as into Spanish.

Thanks again, and keep up the great work!

@beeradmoore
Copy link
Owner Author

I figured I needed a master issue to keep track of them all, and keep track of where I am in being able to have the core system working before others can do it.

@DutraGames
Copy link
Contributor

Hey @beeradmoore, how's it going?

Just a suggestion if it's feasible, instead of creating the folders outside of a parent folder, as shown in the image:

Image for Folders

Would it be possible to use WINUI 3 with the following layout:
Image for lang

@beeradmoore
Copy link
Owner Author

Unfortunately not. Those folders are not created by DLSS Swapper but by one or a few of the nugets it loads

That is unless there is a setting or something I am unaware of to tell it where to load application dlls from

I was excited to try the "build single executable" feature which spits out a single executable file with everything contained in it but it's a lie. It actually just extracts itself into local app data. Was doing it for portable apps but a portable app that leaves files behind almost defeats the purpose

@beeradmoore
Copy link
Owner Author

But to add to this, translations will not live in those folders and they themselves will be their own folder. So at least seeing translation files will be easy!

@DutraGames
Copy link
Contributor

Thank you! I’ll be looking forward to contributing more and more to the project!

@everland-3769
Copy link

Hey there! This project has been a huge help to me! I’d love to share it with others who speak the same language as I do. But before that, the app needs to be translated, so I’d love to contribute by helping with the Traditional Chinese translation. I’m really looking forward to the project opening up for community contributions!

@beeradmoore
Copy link
Owner Author

Thanks @everland-3769 , I have pushed your comment to a new issue and tracked it within this issue. When the app is ready I'll get in contact with you there and if you are still free to help that would be amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request translation
Projects
None yet
Development

No branches or pull requests

3 participants