Skip to content

Commit 2b4cb2a

Browse files
authored
Merge pull request #6 from beclab/fix/backup-state-check
Check backup labels when restore
2 parents d81578b + bc2b214 commit 2b4cb2a

File tree

1 file changed

+17
-2
lines changed

1 file changed

+17
-2
lines changed

pkg/controller/redisclusterbackup/redisclusterbackup_controller.go

+17-2
Original file line numberDiff line numberDiff line change
@@ -208,10 +208,25 @@ func (r *ReconcileRedisClusterBackup) Reconcile(ctx context.Context, request rec
208208
return reconcile.Result{}, err
209209
}
210210

211+
ib, _ := json.Marshal(instance)
212+
reqLogger.Info("[BACKUP] reconcile instance",
213+
"-", "-",
214+
"labels", instance.ObjectMeta.Labels,
215+
"data", string(ib),
216+
)
217+
211218
if instance.Status.Phase == v1alpha1.BackupPhaseSucceeded {
212219
return reconcile.Result{}, nil
213220
}
214221

222+
labels := instance.ObjectMeta.Labels
223+
if labels != nil {
224+
_, ok := labels["velero.io/restore-name"]
225+
if ok {
226+
return reconcile.Result{}, nil
227+
}
228+
}
229+
215230
if instance.ObjectMeta.Annotations != nil {
216231
cfg, ok := instance.ObjectMeta.Annotations["kubectl.kubernetes.io/last-applied-configuration"]
217232
if ok && cfg != "" {
@@ -223,13 +238,13 @@ func (r *ReconcileRedisClusterBackup) Reconcile(ctx context.Context, request rec
223238
"phase", lastBackup.Status.Phase)
224239
if lastBackup.Status.Phase == v1alpha1.BackupPhaseSucceeded {
225240
instance.Status = lastBackup.Status
226-
err := r.crController.UpdateCRStatus(instance)
227-
return reconcile.Result{}, err
241+
return reconcile.Result{}, nil
228242
}
229243
}
230244
}
231245
}
232246

247+
reqLogger.Info("[BACKUP] create new backup")
233248
//// Check if the RedisClusterBackup instance is marked to be deleted, which is
234249
//// indicated by the deletion timestamp being set.
235250
//isBackupMarkedToBeDeleted := instance.GetDeletionTimestamp() != nil

0 commit comments

Comments
 (0)