Skip to content

Commit f2da1a1

Browse files
committed
Add comment and update changelog
Signed-off-by: Kristoffer Dalby <[email protected]>
1 parent 356b76f commit f2da1a1

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
- Target Go 1.19 for Headscale [#778](https://github.com/juanfont/headscale/pull/778)
88
- Target Tailscale v1.30.0 to build Headscale [#780](https://github.com/juanfont/headscale/pull/780)
99
- Give a warning when running Headscale with reverse proxy improperly configured for WebSockets [#788](https://github.com/juanfont/headscale/pull/788)
10+
- Fix subnet routers with Primary Routes [#811](https://github.com/juanfont/headscale/pull/811)
1011

1112
## 0.16.4 (2022-08-21)
1213

machine.go

+5
Original file line numberDiff line numberDiff line change
@@ -642,6 +642,11 @@ func (machine Machine) toNode(
642642

643643
allowedIPs = append(allowedIPs, machine.EnabledRoutes...)
644644

645+
// TODO(kradalby): This is kind of a hack where we say that
646+
// all the announced routes (except exit), is presented as primary
647+
// routes. This might be problematic if two nodes expose the same route.
648+
// This was added to address an issue where subnet routers stopped working
649+
// when we only populated AllowedIPs.
645650
primaryRoutes := []netip.Prefix{}
646651
if len(machine.EnabledRoutes) > 0 {
647652
for _, route := range machine.EnabledRoutes {

0 commit comments

Comments
 (0)