Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another meson tree sitter #7

Closed
gdamore opened this issue Nov 2, 2022 · 2 comments
Closed

Another meson tree sitter #7

gdamore opened this issue Nov 2, 2022 · 2 comments

Comments

@gdamore
Copy link

gdamore commented Nov 2, 2022

I just discovered this implementation of a meson tree-sitter, and unfortunately I discovered this after I implemented my own at

https://github.com/staysail/tree-sitter-meson

Comparing, it looks like your has at least one bug with break and continue (which is also a bug in the documented grammar for meson). I think my version is probably superior to yours -- it's definitely superior to the one at https://github.com/Decodetalkers/tree-sitter-meson -- which is the one I am referring to in the README.

I had no idea that I was creating a third grammar for meson lol.

Anyway, had I known about yours, I'd probably have just submitted a PR here to your grammar. Having said that, I'm going to keep mine around for the moment -- it does have some richer queries... for the record the way I found this grammar was when I went into Helix thinking to add meson and discovering this was already there.

I'm going to propose helix switch to mine in a PR, mostly because of the bug fixes and richer queries -- I hope you don't mind. If you would prefer instead to update this grammar, with the relevant fixes, that would be fine too.

@fasterthanlime
Copy link
Contributor

Hi there! I don't mind you suggest helix switch to yours. I don't have time to compare them right now, but I threw mine together quickly to get basic highlighting on my blog and it's probably easy to do better!

@gdamore
Copy link
Author

gdamore commented Nov 2, 2022

I'm going to close this for now.

@gdamore gdamore closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants