Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reserve command - reserve-with-timeout only option #53

Closed
divmgl opened this issue Dec 27, 2021 · 2 comments
Closed

No reserve command - reserve-with-timeout only option #53

divmgl opened this issue Dec 27, 2021 · 2 comments

Comments

@divmgl
Copy link

divmgl commented Dec 27, 2021

Hi @kr. I'm about to fork this library and add the functionality to reserve a job indefinitely.

This was quite a while ago (almost nine years, wow) but I'm wondering if there's a reason why this is omitted from this library? Is the recommendation to not reserve indefinitely and always provide a timeout? Here's the line in question.

https://github.com/beanstalkd/go-beanstalk/blob/master/tubeset.go#L30

@divmgl divmgl changed the title No "Reserve" command No reserve command - reserve-with-timeout only option Dec 27, 2021
@divmgl
Copy link
Author

divmgl commented Dec 28, 2021

It looks like there's a proposal to get this in: #50.

@divmgl
Copy link
Author

divmgl commented Dec 29, 2021

I made a beanstalkd client that has reserve. https://github.com/getjackd/go-jackd

@divmgl divmgl closed this as completed Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant