Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing channels/channel references into purpose-built data structures rather than symbols/strings #1

Closed
jrevels opened this issue Oct 9, 2019 · 2 comments

Comments

@jrevels
Copy link
Member

jrevels commented Oct 9, 2019

It'd be ideal to have something like a string macro e.g. ch"left-eeg.m1" that nicely parses things for you, so that we could conveniently pretty-print the value as the string macro

@jrevels jrevels changed the title parsing channels/channel reference strings into purpose-built data structures rather than symbols/strings parsing channels/channel references into purpose-built data structures rather than symbols/strings Oct 9, 2019
@jrevels jrevels transferred this issue from another repository Dec 24, 2019
@jrevels
Copy link
Member Author

jrevels commented Aug 16, 2020

I'm semi-convinced we should just use something like https://github.com/JuliaSymbolics/SymbolicUtils.jl for this; channel names would just be elements from that package and then we'd overload very basic arithmetic/accessor operations (+, -, mean, ., etc.) between Samples to apply the correct transformation to the channel names. We could then loosen the restrictions in the Onda format to allow for things like + and mean.

@jrevels
Copy link
Member Author

jrevels commented Mar 17, 2021

I think this is obsoleted as of #69

@jrevels jrevels closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant