Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Buffer usage in dependency #136

Closed
oliversalzburg opened this issue Aug 28, 2019 · 2 comments · Fixed by #141
Closed

Deprecated Buffer usage in dependency #136

oliversalzburg opened this issue Aug 28, 2019 · 2 comments · Fixed by #141

Comments

@oliversalzburg
Copy link

  • Version: 5.0.2
  • Platform: Windows

Every time I start c8, I get the following warning:
(node:12776) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

This is because foreground-child uses cross-spawn, which uses new Buffer().

cross-spawn has recently finally resolved this issue, but it'll probably take quite some time until the change trickles downstream.

Maybe an alternative module without deprecate feature usage can be used instead?

@bcoe
Copy link
Owner

bcoe commented Sep 6, 2019

@oliversalzburg this should be addressed in 5.0.3.

@oliversalzburg
Copy link
Author

Awesome. Confirmed working as expected 👍 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants