Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve issues related to RIG move permit types with TPS migration #997

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

john-fletcher-aot
Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot commented Dec 28, 2023

Description

Fix issues with migrated RIG moves. Issues resolved include:

  • Potential duplicate permit numbers generated with random number suffix
  • Multiplicated records in PERMIT_DATA table for RIG moves with multiple vehicles

Also added count of records migrated to ETL_PROCESSES table for tracking.

Note that changes were also made to the SSIS project - this is stored in MOTI SVN and not in git.

Fixes # ORV2-1468 (partial)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Executed migrations from TPS_TEST into local ORBC database using all SSIS scripts, verified no errors and that results in database match expected

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link
Collaborator

@praju-aot praju-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants