Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ORV2-1788 Permit List sorting - state corrections #990

Merged
merged 7 commits into from
Dec 28, 2023
Merged

Conversation

krishnan-aot
Copy link
Collaborator

@krishnan-aot krishnan-aot commented Dec 28, 2023

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot krishnan-aot added dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Dec 28, 2023
@krishnan-aot krishnan-aot changed the title Disable initialSorting state fix: ORV2-1788 Permit List sorting - fixes to state Dec 28, 2023
@krishnan-aot krishnan-aot changed the title fix: ORV2-1788 Permit List sorting - fixes to state fix: ORV2-1788 Permit List sorting - state corrections Dec 28, 2023
@krishnan-aot krishnan-aot removed dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Dec 28, 2023
@erikataot
Copy link
Contributor

yeah something's not quite right...

Screenshot 2023-12-28 115914

@erikataot
Copy link
Contributor

image

Seems addressed now

Copy link
Contributor

@erikataot erikataot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I hope we don't have to constantly touch these bits

Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@krishnan-aot krishnan-aot merged commit d431f31 into main Dec 28, 2023
17 checks passed
@krishnan-aot krishnan-aot deleted the sort branch December 28, 2023 20:36
This was referenced Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants