Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ORV2-1781 Permit Search and Sort through API #964

Merged
merged 30 commits into from
Dec 27, 2023
Merged

feat: ORV2-1781 Permit Search and Sort through API #964

merged 30 commits into from
Dec 27, 2023

Conversation

krishnan-aot
Copy link
Collaborator

@krishnan-aot krishnan-aot commented Dec 26, 2023 •
edited by github-actions bot
Loading

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot
feat: ORV2-1781 Search permit by API
0f78893
@krishnan-aot
Squashed commit of the following:
b9577f0 
commit 0e148da
Merge: 73339ad 5a7d1d4
Author: Krishnan Subramanian <[email protected]>
Date:   Tue Dec 19 16:42:57 2023 -0800

    Merge remote-tracking branch 'origin/main' into ORV2-1780

commit 73339ad
Merge: cb62c39 50788d8
Author: Krishnan Subramanian <[email protected]>
Date:   Tue Dec 19 16:32:34 2023 -0800

    Merge remote-tracking branch 'origin/main' into ORV2-1780

commit cb62c39
Author: Krishnan Subramanian <[email protected]>
Date:   Tue Dec 19 14:14:44 2023 -0800

    Doc update

commit d1a39f2
Merge: 8c34661 38ba5dd
Author: Krishnan Subramanian <[email protected]>
Date:   Tue Dec 19 14:12:24 2023 -0800

    Merge remote-tracking branch 'origin/main' into ORV2-1780

commit 8c34661
Author: Krishnan Subramanian <[email protected]>
Date:   Tue Dec 19 14:09:56 2023 -0800

    ORV2-1781 Sync frontend with backend pagination

commit 52d27d2
Author: Krishnan Subramanian <[email protected]>
Date:   Tue Dec 19 12:17:54 2023 -0800

    ORV2-1780 Sync frontend pagination with backend
@krishnan-aot
Finishing up search
b8ec50c
@krishnan-aot
Committing example
ee66fe7
@krishnan-aot
Merge remote-tracking branch 'origin/main' into se
bfc891b
@krishnan-aot
Passing search Value to API
355b804
@krishnan-aot
Adding ids to columns
788a60e
@krishnan-aot
Set up sorting
5a7b9fd
@krishnan-aot
Merge remote-tracking branch 'origin/main' into se
0e7ebc5
@krishnan-aot
Modifying sort object
e8b9c7e
@krishnan-aot
Merge remote-tracking branch 'origin/main' into se
e2720d1
@krishnan-aot
Better data structure for sort
07a9491
@krishnan-aot
type rename to PaginationAndFilters
54e65fe
@krishnan-aot
even better data structure
3563938
@krishnan-aot
Merge remote-tracking branch 'origin/main' into se
60016e2
@krishnan-aot
Merge remote-tracking branch 'origin/main' into se
98ac338
@krishnan-aot
Merge remote-tracking branch 'origin/main' into se
dd28527
@krishnan-aot
Merge remote-tracking branch 'origin/main' into se
b4af7ac
@krishnan-aot
Merge remote-tracking branch 'origin/main' into se
f440b23
@krishnan-aot
Merge remote-tracking branch 'origin/main' into se
feffd13
@krishnan-aot
Remove sorting functions
7cd0850
@krishnan-aot
Some minor modifications
65f2c39
@krishnan-aot
Merge remote-tracking branch 'origin/main' into se
3dea642
@krishnan-aot krishnan-aot changed the title ORV2-1781 Permit Search and Sort through API feat: ORV2-1781 Permit Search and Sort through API Dec 26, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions

20.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

erikataot
erikataot approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@erikataot erikataot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to hold up - noice

@krishnan-aot krishnan-aot merged commit ddc7ff7 into main Dec 27, 2023
16 of 17 checks passed
@krishnan-aot krishnan-aot deleted the se branch December 27, 2023 20:26
This was referenced Feb 10, 2024
Closed
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikataot erikataot erikataot approved these changes

@zgong-gov zgong-gov Awaiting requested review from zgong-gov zgong-gov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krishnan-aot @erikataot @cberg-aot