Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ORV2 2070 : Document generation and notification services - Final Iteration #1322

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Apr 9, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

  1. Set up a new module to generate permit and receipt document. The module is imported by application and permit modules to generate receipts and issue, void or revoke permit documents. The new functions in the new module will also allow to reuse the methods for Cron Job ( Doc Gen failure scenarios)
  2. Reworked email notification resend as per latest discussion. Removed overloading of resend.
  3. Refactor and code clean up

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • npm run test:e2e

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

1) Set up a new module to generate permit and receipt document. The module is imported by application and permit modules to generate receipts and issue, void or revoke permit documents. The new functions in the new module will also allow to reuse the methods for Cron Job ( Doc Gen failure scenarios)
2) Rewoked email notification resend as per latest discussion. Removed overloading of resend.
3) Refactor and code clean up
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
1.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@praju-aot praju-aot merged commit 581ecf3 into main Apr 9, 2024
17 of 18 checks passed
@praju-aot praju-aot deleted the ORV2-2070-v3 branch April 9, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant