Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ORV2-2196 - Add pendingPermits Optional query param to GET Applications. #1303

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Apr 3, 2024

Description

Include an optional query parameter named pendingPermits in the GET Applications request. This parameter can accept boolean values: true or false. When true is specified, the endpoint will return only applications with pending permits. Conversely, if false is provided, the endpoint will return applications excluding those with pending permits. If this parameter is not included in the request, the endpoint will return both active applications and those with pending permits.

Note: FE has to make changes to GET /applications endpoint to pass pendingPermits optional query Param as false to exclude them in AIP tab.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • npm run test:e2e
    image
    image

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarqubecloud bot commented Apr 3, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
13.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Apr 3, 2024

@praju-aot praju-aot merged commit 5b4a6e3 into main Apr 3, 2024
18 of 19 checks passed
@praju-aot praju-aot deleted the ORV2-2196 branch April 3, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants