Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: ORV2-1946 Remove Extra Call to Applications API #1274

Merged
merged 16 commits into from
Mar 22, 2024

Conversation

erikataot
Copy link
Contributor

@erikataot erikataot commented Mar 20, 2024

Description

  • Move the applicationsInProgress query to make use of the existing useQuery
  • Fixes the "chip" counter on the Applications In Progress tab to reflect what's in progress

Screenshot 2024-03-19 171413

image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link
Collaborator

@zgong-gov zgong-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the second part of the ticket? The chip count update after deleting one/multiple of these applications in progress?

@erikataot erikataot added dont merge a branch for anything that shouldn't be merged (yet or ever) and removed dont merge a branch for anything that shouldn't be merged (yet or ever) labels Mar 21, 2024
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
17.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@erikataot erikataot merged commit 80e384d into main Mar 22, 2024
17 of 18 checks passed
@erikataot erikataot deleted the ORV2-1946-remove-extra-call-to-applications-api branch March 22, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants