generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: ORV2-1946 Remove Extra Call to Applications API #1274
Merged
erikataot
merged 16 commits into
main
from
ORV2-1946-remove-extra-call-to-applications-api
Mar 22, 2024
Merged
Feat: ORV2-1946 Remove Extra Call to Applications API #1274
erikataot
merged 16 commits into
main
from
ORV2-1946-remove-extra-call-to-applications-api
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zgong-gov
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the second part of the ticket? The chip count update after deleting one/multiple of these applications in progress?
zgong-gov
reviewed
Mar 20, 2024
frontend/src/features/permits/components/dashboard/PermitLists.tsx
Outdated
Show resolved
Hide resolved
krishnan-aot
requested changes
Mar 20, 2024
erikataot
commented
Mar 20, 2024
zgong-gov
requested changes
Mar 20, 2024
frontend/src/features/permits/components/dashboard/PermitLists.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/permits/components/dashboard/PermitLists.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/permits/components/permit-list/ApplicationsInProgressList.tsx
Show resolved
Hide resolved
frontend/src/features/permits/components/permit-list/ApplicationsInProgressList.tsx
Show resolved
Hide resolved
zgong-gov
reviewed
Mar 20, 2024
frontend/src/features/permits/components/permit-list/ApplicationsInProgressList.tsx
Show resolved
Hide resolved
frontend/src/features/permits/components/permit-list/ApplicationsInProgressList.tsx
Outdated
Show resolved
Hide resolved
krishnan-aot
approved these changes
Mar 22, 2024
zgong-gov
approved these changes
Mar 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
applicationsInProgress
query to make use of the existinguseQuery
Applications In Progress
tab to reflect what's in progressFixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are promoted to:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are promoted to: