Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ORV2-2083 - Update Permit template names to generic ones. #1258

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Mar 8, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Update permit template and file names to exclude TROS so that it can be share by multiple permit types.
Fix v_22_test.sh file name.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • docker compose up -d --build sql-server-db

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Update permit template and file names to exclude TROS so that it can be share by multiple permit types

Fix v_22_test.sh file name.
@praju-aot praju-aot added the dont merge a branch for anything that shouldn't be merged (yet or ever) label Mar 8, 2024
@praju-aot
Copy link
Collaborator Author

Waiting to merge #1244 first

Copy link

Copy link

@praju-aot praju-aot merged commit 6ae4e51 into main Mar 11, 2024
18 checks passed
@praju-aot praju-aot deleted the ORV2-2083 branch March 11, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont merge a branch for anything that shouldn't be merged (yet or ever)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants