Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ORV2-1992 Limit date range to 31 days for reports #1230

Merged
merged 23 commits into from
Feb 28, 2024
Merged

Conversation

krishnan-aot
Copy link
Collaborator

@krishnan-aot krishnan-aot commented Feb 28, 2024

Description

Max Range of 31 days:
image

Error message when user tries a value beyond 31 days:
image

Restricted range when user opens the calendar
image

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • npm run test:e2e

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot krishnan-aot added dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Feb 28, 2024
@krishnan-aot krishnan-aot changed the title feat: ORV2-1992 Limit date range to 1 month for reports feat: ORV2-1992 Limit date range to 31 days for reports Feb 28, 2024
Copy link
Collaborator

@praju-aot praju-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@praju-aot praju-aot removed dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Feb 28, 2024
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
11.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
11.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@krishnan-aot krishnan-aot merged commit 749e294 into main Feb 28, 2024
16 of 18 checks passed
@krishnan-aot krishnan-aot deleted the limit branch February 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants