Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ORV2-1987 Add DBA to ManageProfile\CompanyInfo #1209

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Feb 15, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Add DBA field to ManageProfile\CompanyInfo

Fixes # (issue)
https://jira.th.gov.bc.ca/browse/ORV2-1987

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

image
image

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@praju-aot praju-aot added dont review dont merge a branch for anything that shouldn't be merged (yet or ever) and removed dont review labels Feb 15, 2024
@praju-aot praju-aot removed the dont merge a branch for anything that shouldn't be merged (yet or ever) label Feb 15, 2024
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
22.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@praju-aot praju-aot merged commit a88552f into main Feb 15, 2024
16 of 17 checks passed
@praju-aot praju-aot deleted the ORV2-1987 branch February 15, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants