Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ORV2-1986 Company name search will search both legal and alternate name #1208

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Fix: ORV2-1986 Company name search will search both legal and alternate name #1208

merged 2 commits into from
Feb 15, 2024

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Feb 15, 2024 •
edited by github-actions bot
Loading

Description

Company name search will search both legal and alternate name
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • npm run test:e2e

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc vehicles'

Issues
0 New issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc frontend'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@praju-aot praju-aot merged commit 2567f39 into main Feb 15, 2024
34 checks passed
@praju-aot praju-aot deleted the ORV2-1986 branch February 15, 2024 18:21
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnan-aot krishnan-aot krishnan-aot approved these changes

@gchauhan-aot gchauhan-aot Awaiting requested review from gchauhan-aot gchauhan-aot is a code owner

@erikataot erikataot Awaiting requested review from erikataot

@zgong-gov zgong-gov Awaiting requested review from zgong-gov zgong-gov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praju-aot @krishnan-aot