Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: ORV2-1933 Update PayBC Redirection Flow #1189

Merged
merged 19 commits into from
Feb 13, 2024

Conversation

erikataot
Copy link
Contributor

@erikataot erikataot commented Feb 13, 2024

Description

  • Update the PayBC Redirection Url passing from the backend to the frontend

image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc vehicles'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
34.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@krishnan-aot krishnan-aot added the dont merge a branch for anything that shouldn't be merged (yet or ever) label Feb 13, 2024
@erikataot erikataot merged commit 9d13da8 into main Feb 13, 2024
17 of 18 checks passed
@erikataot erikataot deleted the ORV2-1933-update-paybc-redirection-flow branch February 13, 2024 19:05
@erikataot erikataot removed the dont merge a branch for anything that shouldn't be merged (yet or ever) label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants