Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Updated PayBC Sequence and State Diagrams #1149

Merged
merged 2 commits into from
Feb 6, 2024
Merged

docs: Updated PayBC Sequence and State Diagrams #1149

merged 2 commits into from
Feb 6, 2024

Conversation

john-fletcher-aot
Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot commented Feb 6, 2024 •
edited by github-actions bot
Loading

Description

Update PayBC sequence diagram to reflect actual behaviour. Added state diagram to identify possible states after failure in any part of the chain.

Fixes # ORV2-1317 (partial

Type of change

  • Documentation

How Has This Been Tested?

N/A

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (N/A)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

praju-aot
praju-aot approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@praju-aot praju-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@john-fletcher-aot john-fletcher-aot merged commit 77f9e96 into main Feb 6, 2024
16 checks passed
@john-fletcher-aot john-fletcher-aot deleted the ORV2-1317 branch February 6, 2024 21:44
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikataot erikataot erikataot left review comments

@praju-aot praju-aot praju-aot approved these changes

@gchauhan-aot gchauhan-aot Awaiting requested review from gchauhan-aot gchauhan-aot is a code owner

@krishnan-aot krishnan-aot Awaiting requested review from krishnan-aot krishnan-aot is a code owner

@zgong-gov zgong-gov Awaiting requested review from zgong-gov zgong-gov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-fletcher-aot @praju-aot @erikataot