Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: ORV2-1500 Handle Non-CA or USA Provinces #1124

Merged
merged 7 commits into from
Jan 30, 2024

Conversation

erikataot
Copy link
Contributor

@erikataot erikataot commented Jan 30, 2024

Description

Screenshot 2024-01-30 091855

  • Put in some logic to just not display the Province name if it cannot be found in the USA or Canada

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot krishnan-aot added the dont merge a branch for anything that shouldn't be merged (yet or ever) label Jan 30, 2024
@praju-aot praju-aot closed this Jan 30, 2024
@praju-aot praju-aot reopened this Jan 30, 2024
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions

4.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@erikataot erikataot removed the dont merge a branch for anything that shouldn't be merged (yet or ever) label Jan 30, 2024
@erikataot erikataot merged commit b7dbc52 into main Jan 30, 2024
16 of 17 checks passed
@erikataot erikataot deleted the ORV2-1500-handle-non-province-display branch January 30, 2024 21:45
This was referenced Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants