Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ORV2-1887 Configure HQADMIN and FINANCE user groups in onRouteBC #1112

Merged
merged 14 commits into from
Jan 24, 2024

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Jan 24, 2024

Description

The PR configures HQADMIN and FINANCE user groups in onRouteBC.
It also add necessary roles listed below:
'ORBC-READ-SPECIAL-AUTH',
'ORBC-READ-NOFEE',
'ORBC-WRITE-NOFEE',
'ORBC-READ-LCV-FLAG',
'ORBC-WRITE-LCV-FLAG',
'ORBC-READ-LOA',
'ORBC-WRITE-LOA'

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • npm run test:e2e
  • Deployment and manual testing

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc dops'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc vehicles'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions

35.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@praju-aot praju-aot merged commit d95fed6 into main Jan 24, 2024
18 of 19 checks passed
@praju-aot praju-aot deleted the ORV2-1887-1 branch January 24, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants