feat: Upgrade nestjs from 9 to 10, node from 18 to 20 and other dependencies #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praju-aot
requested review from
cberg-aot,
gchauhan-aot,
john-fletcher-aot,
krishnan-aot and
zgong-gov
as code owners
erikataot
reviewed
Jan 23, 2024
There was a problem hiding this comment.
- All test suites passed for me using
npm run test:cov - App seemed to run ok, could login with BCeid and purchase permit, and update trailer and vehicle without issue
- Could login as IDIR and search for the purchased permit
When we're ready to merge, this should be good for approval
krishnan-aot
approved these changes
Jan 23, 2024
|
|
|
This was referenced Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
The PR upgrades the NODE version to latest LTS (v20) and NestJS to v10 along with other upgrades.
vehicles-api
dops-api
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are promoted to: