Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Alter TPS migration permit trigger to handle superseded #1092

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

john-fletcher-aot
Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot commented Jan 15, 2024

Description

Fixing the following issues with TPS permit sync:

  • Migrated amendments not marking the previous TPS permits SUPERSEDED
  • Possibility of inserting duplicate records into ORBC_PERMIT
  • Not maintaining exact ORBC permit number across amendments

Fixes # ORV2-1862

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Ran migration script locally, verified no errors present in docker console
  • Verified manually the trigger was updated using SSMS
  • Added duplicate record to migration table, verified no duplicate was added to ORBC_PERMIT or ORBC_PERMIT_DATA
  • Added new revision of TPS permit manually, verified previous record marked SUPERSEDED and that the permit number correctly matches previous version's permit number

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (N/A)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (TBD)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants