Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ORV2-1341 - Fix Province Input Rendering Issues When Country Changes/Initially Set #1089

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

zgong-gov
Copy link
Collaborator

@zgong-gov zgong-gov commented Jan 13, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

  • Fixes rendering issues for the province input when the country is changed or initially set

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Go to the create new application form, and observe that initially both the country and province input fields are present with empty values
  • On the same application form, choose a vehicle from the dropdown and observe that the country and province inputs are now filled with the appropriate values from the vehicle details. Switch the country to "Mexico" or "Other", and observe that the province input is now hidden. After switching the country to "Mexico", click continue and observe on the review page that the country is now "Mexico" and province is empty
  • From this review page, click "Edit" (or breadcrumb at the top) to go back to the form, and observe that "Mexico" is still selected as the country, and province input field should be hidden. Choose a different vehicle (one with both country and province), and observe that both country and province input fields are available again with the updated values. Click continue to go to the review page, and observe that the country and province values are updated correctly.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
97.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@erikataot erikataot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holds up for me - nice work

@zgong-gov zgong-gov merged commit bb190b5 into main Jan 15, 2024
25 checks passed
@zgong-gov zgong-gov deleted the ORV2-1341 branch January 15, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants