Skip to content

Commit

Permalink
fix: Trying with no name fields (#961)
Browse files Browse the repository at this point in the history
  • Loading branch information
cberg-aot authored Dec 22, 2023
1 parent a9d4cc0 commit 2e6a90b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 37 deletions.
10 changes: 2 additions & 8 deletions .github/workflows/notifications.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,28 +10,22 @@ on:
- 'common/graphics/**'
- '!.github/workflows/deploy.yml'
- '!.github/workflows/merge.yml'
issue_comment:
pull_request_review:
pull_request_review_comment:
jobs:
vars:
name: Set Variables
outputs:
pr: ${{ steps.pr.outputs.pr }}
runs-on: ubuntu-22.04
timeout-minutes: 1
steps:
# Get PR number for squash merges to main
- name: PR Number
id: pr
- id: pr
uses: bcgov-nr/[email protected]

notify-teams:
needs: [vars]
runs-on: ubuntu-22.04
steps:
- name: MS Teams Notifications
uses: dchourasia/[email protected]
- uses: dchourasia/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
webhook-uri: ${{ vars.MS_TEAMS_WEBHOOK_URI }}
Expand Down
14 changes: 0 additions & 14 deletions .github/workflows/pr-close.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,3 @@ jobs:
repository: ${{ github.repository }}/${{ matrix.package }}
target: ${{ github.event.number }}
tags: latest

notify-teams-dev:
name: Notify Teams - Dev
runs-on: ubuntu-22.04
steps:
- name: MS Teams Notifications
uses: dchourasia/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
webhook-uri: ${{ vars.MS_TEAMS_WEBHOOK_URI }}
custom-facts: |
- name: Notify
value: "Successful Merge of ${{ github.event.number }}"
show-on-exit: false
15 changes: 0 additions & 15 deletions .github/workflows/pr-open.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,18 +87,3 @@ jobs:
triggers: ('tps-migration' 'dops/' 'frontend/' 'vehicles/')
vault_role: nonprod
vault_zone: dev

notify-teams-dev:
name: Notify Teams - Dev
needs: [deploys, vars]
runs-on: ubuntu-22.04
steps:
- name: MS Teams Notifications
uses: dchourasia/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
webhook-uri: ${{ vars.MS_TEAMS_WEBHOOK_URI }}
custom-facts: |
- name: Notify
value: "Successful Deploy of ${{ needs.vars.outputs.pr }} to DEV"
show-on-exit: false

0 comments on commit 2e6a90b

Please sign in to comment.