Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): abort outdated requests #1317

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Nov 13, 2024

Description

This was specially aimed at aborting outdated requests for the data-fetcher component, used for auto-completes.
But this can also be used on higher scopes, since it required updating the useFetch composable.
This is useful because when a client application aborts the request, it doesn't need to spend time/bandwidth to download the corresponding response later.
And hopefully in the future, aborting a request can also be signaled to the server and the server can abort the corresponding processing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Contributor

Current changelog

Features

  • abort outdated requests (0e17554)
  • remove unused variable (bd2bb5c)
  • use the aborted status instead of timestamps (626e27b)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants