Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe:FSADT1-1508): prevent error on Date of birth before using it #1204

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Oct 2, 2024

Description

Prevents the error message on Date of birth which appears when a Sole proprietorship that "already exists" or is "not owned by a person" gets selected, by waiting to render the Date of birth field after the client data is returned, like we do for all the other fields.
(This addresses the Note 2 on FSADT1-1508. The main fixes PR for FSADT1-1508 - #1191 - are already merged)

Fixes FSADT1-1508

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Current changelog

Bug Fixes

  • prevent error on Date of birth before using it (e7b21dc)

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@fterra-encora fterra-encora changed the title fix(fe:FSADT1-1511): prevent error on Date of birth before using it fix(fe:FSADT1-1508): prevent error on Date of birth before using it Oct 2, 2024
@fterra-encora fterra-encora merged commit ce75def into main Oct 2, 2024
34 checks passed
@fterra-encora fterra-encora deleted the fix/FSADT1-1508-2 branch October 2, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants