Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle large layers that are on GH releases differently #62

Closed
ateucher opened this issue Jun 11, 2020 · 8 comments · Fixed by #115
Closed

Handle large layers that are on GH releases differently #62

ateucher opened this issue Jun 11, 2020 · 8 comments · Fixed by #115

Comments

@ateucher
Copy link
Collaborator

Attempt to use bcdata to get them and cache

@stephhazlitt stephhazlitt added this to the v0.2 milestone Jun 12, 2020
@boshek
Copy link
Collaborator

boshek commented Aug 28, 2020

For now we are continuing to use the bcmapsdata release

@stephhazlitt stephhazlitt removed this from the v0.2 milestone Sep 1, 2020
@boshek
Copy link
Collaborator

boshek commented Sep 25, 2020

Other options include:

  • Add to bcmaps repo (☝️ maintenance)
  • Download directly from WFS

@ateucher ateucher removed the wontfix label Aug 26, 2022
@ateucher
Copy link
Collaborator Author

I think we should address this actually. Hosting the large layers on bcmapsdata is an albatross - the boundaries change (I know bec is in need of an update), and the process over in bcmapsdata is tied up into releasing the whole package. It also relies on a git workflow that I'm not certain will still work out of the box (with changes to best practices for authentication etc).

@ateucher
Copy link
Collaborator Author

Timings for downloading from WFS (I have a very fast connection):

> system.time(tsa <- bcdc_get_data("8daa29da-d7f4-401c-83ae-d962e3a28980"))
   user  system elapsed 
 27.220   8.925 244.023

> system.time(bec <- bcdc_get_data("f358a53b-ffde-4830-a325-a5a03ff672c3"))
This object has 15666 records and requires 16 paginated requests to complete.
Retrieving data
  |===================================================================================| 100%
Parsing data
   user  system elapsed 
 86.032  17.948 380.226

@boshek
Copy link
Collaborator

boshek commented Aug 26, 2022

That doesn't seem too too bad really. Is the proposal to just handle these the same as the rest of the layers?

@ateucher
Copy link
Collaborator Author

That's one of the proposals - I agree it's probably not too bad since it gets cached... I worry a bit for people with poor internet though. The major benefit is no maintenance from us, and it's always up to date. I think the other option is to bundle them into the releases in this repo rather than bcmapsdata.

@stephhazlitt
Copy link
Member

I suggest we canvass the community re: internet speed and the download size -- maybe a Tweet with a reprex? We could ask colleagues in remote locations (where internet is slower) to try and report?

@ateucher
Copy link
Collaborator Author

Based on user testing in remote locations with slower/unreliable internet, we will choose option 2: move the tsa and bec functions to the same pattern as the others; i.e., a wrapper around bcdc_get_data, with caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants