#4397 - Fix CSGD (CSG - PTDEP) [PT 24/25] #4399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh16011993
added
E2E/Unit tests
Camunda Worflow
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
reviewed
Feb 26, 2025
| @@ -50,7 +50,7 @@ describe(`E2E Test Workflow parttime-assessment-${PROGRAM_YEAR}-awards-amount-CS | |||
| calculatedAssessment.variables.dmnPartTimeAwardFamilySizeVariables | |||
| .limitAwardCSGDIncomeCap, | |||
| ); | |||
| expect(calculatedAssessment.variables.federalAwardCSGDAmount).toBe(1260); | |||
| expect(calculatedAssessment.variables.federalAwardNetCSGDAmount).toBe(1260); | |||
There was a problem hiding this comment.
Minor. federalAwardCSGDAmount is renamed to federalAwardMaxCSGDAmount. Hence an an assert to check
expect(calculatedAssessment.variables.federalAwardMaxCSGDAmount).toBe(1260);There was a problem hiding this comment.
Please ignore this for hotfix PR. It can be accommodated in other PR to main.
|
As it is a hotfix, the changes are ignored for 2025-2026 PY and the PY before 2024-2025 ? Other than the above just a minor comment. |
dheepak-aot
approved these changes
Feb 26, 2025
andrewsignori-aot
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Approving as it is since it is a last-minute fix for the 2.5 release but please ensure the other program years will be updated in the main as mentioned by @dheepak-aot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following was fixed:
federalAwardCSGDAmounttofederalAwardMaxCSGDAmountScreenshot:
federalAwardNetCSGDAmountcalculation to take the minimum value of remaining need, max calculated, and PY award limit less previously awarded value.Screenshot:
Screenshot: