Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4235 - Student File Upload - Reset after submit #4349

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Feb 12, 2025

Student File Upload - Reset after submit

  • Updated the formio object typed with resetValue from the formio SDK library. resetValue() is expected to do more than just resetting the values like setting the form to pristine .etc.
  • Using reset and redraw to mitigate the error shown in student uploader after submit.

image

image

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.11% ( 3914 / 17704 )
Methods: 9.96% ( 226 / 2268 )
Lines: 25.46% ( 3380 / 13276 )
Branches: 14.26% ( 308 / 2160 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 87.58% ( 1418 / 1619 )
Methods: 84.66% ( 160 / 189 )
Lines: 89.72% ( 1170 / 1304 )
Branches: 69.84% ( 88 / 126 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 69.95% ( 6282 / 8981 )
Methods: 67.39% ( 773 / 1147 )
Lines: 73.7% ( 4907 / 6658 )
Branches: 51.19% ( 602 / 1176 )

@dheepak-aot dheepak-aot marked this pull request as ready for review February 12, 2025 20:14
@dheepak-aot dheepak-aot self-assigned this Feb 12, 2025
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dheepak-aot 👍

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants