Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4014 - Institution Read-Only User Type PART 2 (UI) (Part 3) #4346

Merged

Conversation

lewischen-aot
Copy link
Collaborator

@lewischen-aot lewischen-aot commented Feb 12, 2025

This PR removes the two buttons related to program and offering executions for read-only users:

  • Removed button "+ Create program" on the PIR page.
  • Removed dropdown button "Edit offering" on the offering edit page.

Screenshots
image

image

@lewischen-aot lewischen-aot added Enhancement New feature or request Institution Institution Features Form.io Form IO definitions changed. Web portal labels Feb 12, 2025
@lewischen-aot lewischen-aot self-assigned this Feb 12, 2025
@lewischen-aot lewischen-aot marked this pull request as ready for review February 12, 2025 00:55
"when": null,
"eq": "",
"json": ""
},
"customConditional": "",
"customConditional": "show = data['isReadOnlyUser'] !== true;",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to string property access, it can be show = data.isReadOnlyUser !== true

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes, looks good 👍

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.11% ( 3914 / 17704 )
Methods: 9.96% ( 226 / 2268 )
Lines: 25.46% ( 3380 / 13276 )
Branches: 14.26% ( 308 / 2160 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 87.58% ( 1418 / 1619 )
Methods: 84.66% ( 160 / 189 )
Lines: 89.72% ( 1170 / 1304 )
Branches: 69.84% ( 88 / 126 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 69.95% ( 6282 / 8981 )
Methods: 67.39% ( 773 / 1147 )
Lines: 73.7% ( 4907 / 6658 )
Branches: 51.19% ( 602 / 1176 )

@lewischen-aot lewischen-aot added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 19225f6 Feb 12, 2025
21 checks passed
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Form.io Form IO definitions changed. Institution Institution Features Web portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants