-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4014 - Institution Read-Only User Type PART 2 (UI) (Part 3) #4346
#4014 - Institution Read-Only User Type PART 2 (UI) (Part 3) #4346
Conversation
"when": null, | ||
"eq": "", | ||
"json": "" | ||
}, | ||
"customConditional": "", | ||
"customConditional": "show = data['isReadOnlyUser'] !== true;", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to string property access, it can be show = data.isReadOnlyUser !== true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick changes, looks good 👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR removes the two buttons related to program and offering executions for read-only users:
Screenshots
