Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4247 - Create Application Versioning (Part 2) #4326

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

sh16011993
Copy link
Collaborator

As a part of this PR, the following was completed:

  • Added Indexes for the parent_application_id and preceding_application_id columns.

@sh16011993 sh16011993 self-assigned this Feb 6, 2025
@sh16011993 sh16011993 added the DB DB migration involved label Feb 6, 2025

CREATE INDEX parent_application_id_idx ON sims.applications (parent_application_id);

COMMENT ON INDEX sims.parent_application_id_idx IS 'Index created on parent_application_id_idx to improve the performance of data retrieval.';
Copy link
Collaborator

@dheepak-aot dheepak-aot Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Index created on parent_application_id?

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link

github-actions bot commented Feb 6, 2025

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.23% ( 3902 / 17551 )
Methods: 10.14% ( 226 / 2229 )
Lines: 25.57% ( 3368 / 13173 )
Branches: 14.33% ( 308 / 2149 )

Copy link

github-actions bot commented Feb 6, 2025

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

github-actions bot commented Feb 6, 2025

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 87.15% ( 1404 / 1611 )
Methods: 84.66% ( 160 / 189 )
Lines: 89.38% ( 1161 / 1299 )
Branches: 67.48% ( 83 / 123 )

Copy link

github-actions bot commented Feb 6, 2025

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.8% ( 6063 / 8943 )
Methods: 65.24% ( 745 / 1142 )
Lines: 71.64% ( 4751 / 6632 )
Branches: 48.5% ( 567 / 1169 )

@sh16011993 sh16011993 added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit ad70cf7 Feb 6, 2025
21 checks passed
@sh16011993 sh16011993 deleted the 4247_create_application_versioning_part_2 branch February 6, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB DB migration involved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants