Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4014 - Institution Read-Only User Type PART 2 (UI) (Part 1) #4325

Merged
merged 7 commits into from
Feb 10, 2025
Merged

#4014 - Institution Read-Only User Type PART 2 (UI) (Part 1) #4325

merged 7 commits into from
Feb 10, 2025

Conversation

lewischen-aot
Copy link
Collaborator

@lewischen-aot lewischen-aot commented Feb 6, 2025 •
edited
Loading

As part of the story, this first PR has the following changes:

  • Added a new user role called 'read-only' located between user and no access on the UI.
  • Updated the UI to prevent actions in the below areas.
    • Program and Offering: prevent user from changing any offering related data
    • PIR: 'Complete Program Info Request' button
    • Confirm enrolment: 'Application Action' drop down button on the 'Confirm Enrolment' screen of a particular application
    • Report a change: 'Submit update' button on the 'report a change' screen of a particular application
    • Request a change: 'Submit requested change' button on the 'Request an application change' screen of a particular application
  • Ensured buttons are disabled across all mentioned areas in the business ACs.
  • Ensured routes are disallowed for program-creation and offering-creation pages for read-only-users.
  • Adjusted the "Add Users" screen to describe the 'read-only' role

Screenshot of the assign-user-role model
Screenshot 2025-02-06 114420

Screenshot of the added item in the list
image

@lewischen-aot lewischen-aot self-assigned this Feb 6, 2025
@lewischen-aot lewischen-aot added Enhancement New feature or request Institution Institution Features Web portal labels Feb 6, 2025
@lewischen-aot lewischen-aot marked this pull request as ready for review February 6, 2025 20:25
andrewsignori-aot
andrewsignori-aot reviewed Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, please take a look at the comments.

andrewsignori-aot
andrewsignori-aot reviewed Feb 10, 2025
View reviewed changes
sources/packages/web/src/components/common/ScholasticStandingForm.vue Outdated
@@ -73,7 +76,7 @@ export default defineComponent({
context.emit("cancel");
};

return { data, submitted, cancel };
return { data, submitted, cancel, isReadOnlyUser };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isReadOnlyUser can be removed now, right?

andrewsignori-aot
andrewsignori-aot approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes, just one minor comment left, hence approving it.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.09% ( 3903 / 17668 )
Methods: 9.98% ( 226 / 2264 )
Lines: 25.42% ( 3369 / 13251 )
Branches: 14.31% ( 308 / 2153 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 87.58% ( 1418 / 1619 )
Methods: 84.66% ( 160 / 189 )
Lines: 89.72% ( 1170 / 1304 )
Branches: 69.84% ( 88 / 126 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 68.41% ( 6118 / 8943 )
Methods: 66.29% ( 757 / 1142 )
Lines: 72.18% ( 4787 / 6632 )
Branches: 49.1% ( 574 / 1169 )

@sh16011993 sh16011993 self-requested a review February 10, 2025 18:21
sh16011993
sh16011993 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @lewischen-aot 👍 Thanks for the PR walkthrough.

@lewischen-aot lewischen-aot added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 9ff0a7a Feb 10, 2025
21 checks passed
@lewischen-aot lewischen-aot deleted the feature/#4014-institution-read-only-user-ui-part-1 branch February 10, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@lewischen-aot lewischen-aot

Labels
Enhancement New feature or request Institution Institution Features Web portal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewischen-aot @sh16011993 @andrewsignori-aot