#4253 - Upgrade Redis - metrics #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enabled: true | ||
| ## Enable this if you're using https://github.com/coreos/prometheus-operator | ||
| ## | ||
| serviceMonitor: |
There was a problem hiding this comment.
Is serviceMonitor required to have metrics enabled?
There was a problem hiding this comment.
yes to expose the metrics to prometheus operator, as we are not using it, disabling it
There was a problem hiding this comment.
So, the answer to the question "Is serviceMonitor required to have metrics enabled" is NO?
There was a problem hiding this comment.
Yes the answer is NO :)
There was a problem hiding this comment.
I would suggest to have it disabled here also.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Metrics to check alerts in sysdig.
Currently only dev namespaces enabled, to test the metrics.
Ignore the below files, as they are copied from bitnami to enable metrics
