#4270 - SFAS Bridge File - Expand Individual and Application data Import #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheepak-aot
changed the title
Comment on lines
+123
to
+124
| get applicationNumber(): number | null { | ||
| return parseInteger(this.line.substring(145, 155)); |
There was a problem hiding this comment.
It's not a blocker, no need to change it, but I have seen the two formats of executing the substring along the files (not this one is specific), 145, 155 vs 127, 127 + 10. I personally prefer the first one but I do not have a strong opinion other than "we should do it in the same way" 😉
There was a problem hiding this comment.
I also saw the 2 formats there. I too prefer the format WITHOUT explicit addition. The existing individual record parser does not have the format with addition and I thought we could agree this way and move forward. I am also mindful about using the addition format for new record types in previous PR.
...packages/backend/libs/integrations/src/sfas-integration/sfas-files/sfas-individual-record.ts
Outdated
Show resolved
Hide resolved
...packages/backend/libs/integrations/src/sfas-integration/sfas-files/sfas-individual-record.ts
Outdated
Show resolved
Hide resolved
...packages/backend/libs/integrations/src/sfas-integration/sfas-files/sfas-individual-record.ts
Show resolved
Hide resolved
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
approved these changes
Feb 7, 2025
bidyashish
reviewed
Feb 7, 2025
...ckend/libs/integrations/src/sfas-integration/sfas-files/sfas-application-dependant.record.ts
Show resolved
Hide resolved
...nd/libs/integrations/src/sfas-integration/sfas-files/sfas-application-disbursement.record.ts
Show resolved
Hide resolved
lewischen-aot
approved these changes
Feb 7, 2025
dheepak-aot
deleted the
enhancement/#4270-sfas-bridge-expansion-file-expand-existing-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFAS Bridge File - Expand Individual and Application data Import
Import of extended data
SFAS IndividualandSFAS Application.SFAS IndividualandSFAS Application.SFAS Individuals
SFAS Applications
E2E Test
SFAS IndividualandSFAS Applicationimport.