#3594 - Email to Student - 2nd Disbursement has passed, still pending (Part 3) #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewischen-aot
added
Student
Comment on lines
394
to
398
| notificationMessage: await db.notificationMessage.findOne({ | ||
| where: { | ||
| id: NotificationMessageType.StudentSecondDisbursementNotification, | ||
| }, | ||
| }), |
There was a problem hiding this comment.
I believe there is no need to execute the db.notificationMessage.findOne to get the notification from DB since its ID is known. Can you please try the below?
const notification = createFakeNotification(
{
user: student.user,
notificationMessage: { id: NotificationMessageType.StudentSecondDisbursementNotification } as NotificationMessage,
},
{
initialValue: {
metadata: { assessmentId: application.currentAssessment.id },
},
},
);| "when a notification is already sent for the second disbursement still pending.", | ||
| async () => { | ||
| // Arrange | ||
| const student = await saveFakeStudent(db.dataSource); |
There was a problem hiding this comment.
Not a blocker, but the student creation will be executed by the saveFakeApplicationDisbursements in case one student is not provided.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
approved these changes
Jan 31, 2025
lewischen-aot
deleted the
feature/#3594-email-to-student-2nd-disbursement-has-passed-part-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the final part of the story, this PR has the following changes: